Feature: Added an action to toggle dual pane mode #17401
Merged
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi @SilverGreen93 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new action to toggle dual pane mode in the Files application, allowing users to easily switch between single and dual pane layouts.
Key changes:
- Added
ToggleDualPaneActionthat enables/disables dual pane mode based on current state - Implemented
CloseOtherPane()method to close the non-active pane when toggling off - Integrated the new command into the command management system
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Files.App/Actions/Show/ToggleDualPaneAction.cs |
New action class implementing toggle functionality for dual pane mode |
src/Files.App/Views/ShellPanesPage.xaml.cs |
Added CloseOtherPane() method to close the non-active pane |
src/Files.App/Data/Contracts/IShellPanesPage.cs |
Added interface definition for CloseOtherPane() method |
src/Files.App/Data/Commands/Manager/CommandManager.cs |
Registered the new toggle dual pane command |
src/Files.App/Data/Commands/Manager/ICommandManager.cs |
Added property for the toggle dual pane command |
src/Files.App/Data/Commands/Manager/CommandCodes.cs |
Added command code enum value for toggle dual pane |
src/Files.App/Strings/en-US/Resources.resw |
Added localized strings for the new action |
yaira2
added
ready to merge
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.