Rust: Make rust/summary/query-sinks less noisy #20042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This is the one in the DCA meta queries output, not the grand total used in metrics.
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR reduces noise in the rust/summary/query-sinks query by filtering out ubiquitous sink types that typically clutter the results. The query is used in DCA meta queries output and for ad-hoc database analysis, where dereference and logging sinks often obscure more interesting security-relevant findings.
- Filters out
AccessInvalidPointer::SinkandCleartextLogging::Sinkfrom query results - Updates documentation to reflect the filtering of ubiquitous sink types
- Adds necessary imports for the filtered sink types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
rust/summary/query-sinksless noisy. This is the one used in the DCA meta queries output, and occasionally used ad-hoc to get a feel for a database - but it is not used in metrics (the counts produced byrust/summary/query-sink-countsandrust/summary/summary-statisticsare not affected by this change). Currently for both uses results for this query are typically clogged with dereference and logging sinks, which obscures and in the case of the DCA meta queries output can completely hide other more interesting results.