Skip to content

Require Ruby 2.3 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ inherit_gem:
jekyll: .rubocop.yml

AllCops:
TargetRubyVersion: 2.1
TargetRubyVersion: 2.3
Exclude:
- vendor/**/*
- spec/*.rb
Expand Down
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ rvm:
- 2.5
- 2.4
- 2.3
- 2.2
env:
- ""
- JEKYLL_VERSION=3.7.0
- JEKYLL_VERSION=3.7.3
matrix:
include:
- # GitHub Pages
Expand Down
4 changes: 2 additions & 2 deletions jekyll-gist.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/jekyll/jekyll-gist"
spec.license = "MIT"

spec.required_ruby_version = ">= 2.1"
spec.required_ruby_version = ">= 2.3.0"

spec.files = `git ls-files -z`.split("\x0")
spec.executables = spec.files.grep(%r!^bin/!) { |f| File.basename(f) }
Expand All @@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "jekyll", ">= 3.0"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec"
spec.add_development_dependency "rubocop", "0.51"
spec.add_development_dependency "rubocop", "~> 0.57"
spec.add_development_dependency "webmock"
end
19 changes: 10 additions & 9 deletions lib/jekyll-gist/gist_tag.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,18 @@ def render(context)
script_tag = gist_script_tag(gist_id, filename)
"#{noscript_tag}#{script_tag}"
else
raise ArgumentError, <<-EOS
Syntax error in tag 'gist' while parsing the following markup:
raise ArgumentError, <<~ERROR
Syntax error in tag 'gist' while parsing the following markup:

#{@markup}
#{@markup}

Valid syntax:
{% gist user/1234567 %}
{% gist user/1234567 foo.js %}
{% gist 28949e1d5ee2273f9fd3 %}
{% gist 28949e1d5ee2273f9fd3 best.md %}
EOS
Valid syntax:
{% gist user/1234567 %}
{% gist user/1234567 foo.js %}
{% gist 28949e1d5ee2273f9fd3 %}
{% gist 28949e1d5ee2273f9fd3 best.md %}

ERROR
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/jekyll-gist/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Jekyll
module Gist
VERSION = "1.5.0".freeze
VERSION = "1.5.0"
end
end