Skip to content

Use Liquid::Tag#raw to clarify error message #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

ashmaroli
Copy link
Member

This is to add clarity to the error message output when the tag is used without any arguments by using Liquid's builtin Liquid::Tag#raw

Currently on master

Liquid Exception: Syntax error in tag 'gist' while parsing the following markup: Valid syntax:
{% gist user/1234567 %} {% gist user/1234567 foo.js %} {% gist 28949e1d5ee2273f9fd3 %} {% gist
28949e1d5ee2273f9fd3 best.md %} in source/_test/doc.md

With the proposed change

Liquid Exception: Syntax error in tag 'gist' while parsing the following markup: '{% gist %}'
Valid syntax: {% gist user/1234567 %} {% gist user/1234567 foo.js %} {% gist 28949e1d5ee2273f9
fd3 %} {% gist 28949e1d5ee2273f9fd3 best.md %} in source/_test/doc.md

@ashmaroli ashmaroli force-pushed the tag-markup-in-error-message branch from 2b12460 to f4a8d31 Compare March 24, 2019 16:19
@ashmaroli ashmaroli changed the title Use LIquid::Tag#raw to clarify error message Use Liquid::Tag#raw to clarify error message Mar 24, 2019
@ashmaroli ashmaroli added the fix label Mar 24, 2019
@ashmaroli ashmaroli requested a review from a team March 24, 2019 16:20
@DirtyF
Copy link
Member

DirtyF commented Jul 16, 2019

Thanks @ashmaroli

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 01941ee into jekyll:master Jul 16, 2019
@jekyllbot jekyllbot added the bug label Jul 16, 2019
jekyllbot added a commit that referenced this pull request Jul 16, 2019
@mattr-
Copy link
Member

mattr- commented Jul 16, 2019

This PR didn't pass CI. I don't understand why it was merged.

If you're going to say, "well, it's just a lint error", then linting our codebase has no value and we should just remove linting from the CI run and stop enforcing our code style.

@DirtyF
Copy link
Member

DirtyF commented Jul 16, 2019

'Well it was just a human error".

It's fixed now: https://travis-ci.org/jekyll/jekyll-gist

@jekyll jekyll locked and limited conversation to collaborators Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants