Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Conversation

adamvoss
Copy link
Contributor

This moves supported draft information out of notes and into a specific member of the object.

Switches the relevant template piece to HTML (from Markdown) because it is more manageable.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I started doing something like this (in the old HTML version) when we published draft-06 but never got very far.

I think removing that one 5 is the only necessary change. Explaining draft-05 is hard even if it's technically supported somewhere, best to focus on 4 and 6.

license: Apache License 2.0
- name: JavaScript
implementations:
- name: ajv
url: https://github.com/epoberezkin/ajv
notes: "for Node.js and browsers - *supports draft 4, draft 6, [custom keywords](https://github.com/epoberezkin/ajv-keywords) and [$data reference](https://github.com/json-schema-org/json-schema-spec/issues/51)*"
notes: "for Node.js and browsers - *supports [custom keywords](https://github.com/epoberezkin/ajv-keywords) and [$data reference](https://github.com/json-schema-org/json-schema-spec/issues/51)*"
draft: [4, 5, 6]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While @epoberezkin can correct me if I'm wrong, I'm pretty sure that AJV's "v5" was draft-04 plus the various keyword proposals that were floating around when the draft-04 authors left the project. It's not entirely clear what it would even mean to say an implementation supported draft-05 as there was no formal way to indicate a schema used that draft, and the only validation change was adding clarifying "uri" and "uri-reference" as a format.

@handrews handrews merged commit f3d6e0c into json-schema-org:master Aug 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants