-
-
Notifications
You must be signed in to change notification settings - Fork 214
Updating of examples / samples #215
Conversation
Thanks so much, @retrosight! I will review this in detail soon. I'd also like to get @Relequestual's review as the lead for the web site. @retrosight there is a test failing in Travis CI for one of the schema files (perhaps it was removed)- can you edit |
Thanks for this! I'm likely to be able to review next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give this man a medal and merge the PR!
Thanks for the vote of confidence, @philsturgeon. ;-) Let's hold off on merging a bit as I'm still working through all of the examples -- one still left to go: @handrews I fixed the build fail. |
The medal will have to wait too. Fair warning I’m on vacation and was just eyeballing the diff from a hammock so somebody needs to confirm it locally, but whatever bike sheds pop up this is infinitely better than what we have now.
|
@Relequestual Ready now for you to review and provide feedback before merging. It looks quite wholesale on the surface yet most of the original content is still there. I tried to respect the intent of the original author(s) as much as I could. It's going to be hard to read unless you are a diff hound. Therefore I suggest you might want to navigate over to... https://github.com/retrosight/json-schema-org.github.io/blob/master/learn/index.md ...and browse the complete collection as it will appear on the site. |
I'll also note I made some changes to |
@retrosight Super thankyou for all the hard work you've clearly done on this. Sorry I wasn't able to review this when I intended. I have now started, but expect to finish today or at most end of next week. |
Merged in #221. Thank you! |
Sorry for being a terrible person. I was actually going to be looking at this today, but I guess I that was still too long to wait for the others. Seriously thanks for your hard work on this. I'll read through the updates today anyway =] |
Great work. I have one small fix to apply and one followup issue to raise. But honestly this is super great! Thanks again! |
With this pull request it's my intent to...