Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Conversation

thomas4019
Copy link

This is a meta tool for modifying JSON schemas using React. I think this is a useful addition because the existing editors do not work well for actually modifying JSON Schemas. Please let me know if I should change anything.

@Relequestual
Copy link
Member

Hey Thomas, Thanks for the PR.
Looks like you made an editor, so please put that under the editor section rather than UI generation.
Cheers

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to Editors section

This is a meta tool for modifying JSON schemas using React.
@thomas4019
Copy link
Author

Good point! I've updated it to now be under the editors section.

@Relequestual
Copy link
Member

Thanks.

Are you planning to update it to work with things like $ref and allOf?
It's not really that useful without these...

@thomas4019
Copy link
Author

Hi Ben,
Thanks for the review. I'm not planning on making these changes at the moment, but once I get around to adding those (and being more fully compliant with the standard) then I'll open a new PR. Thanks!

@thomas4019 thomas4019 closed this Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants