Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Update @cfworker/json-schema validator library info #504

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Update @cfworker/json-schema validator library info #504

merged 2 commits into from
Mar 8, 2023

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Feb 28, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for condescending-hopper-c3ed30 ready!

Name Link
🔨 Latest commit 8fe153e
🔍 Latest deploy log https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/64073c43175e69000896cff2
😎 Deploy Preview https://deploy-preview-504--condescending-hopper-c3ed30.netlify.app/implementations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gregsdennis
Copy link
Member

@jdesrosiers @Julian is this mixed content thing new? The changes have no effect on this.

@jdesrosiers
Copy link
Member

is this mixed content thing new?

That wasn't there when I merged website updates last week. It's referring to external links in IETF generated documents. There isn't anything we can do about this even if it was a real problem. I'd say we can merge this PR and have @Relequestual look into the Netlify settings to see if we can turn that check off or at least make it a warning or something.

@gregsdennis
Copy link
Member

gregsdennis commented Mar 1, 2023

@awwright is this something that went in as part of your tooling update? (Maybe that was contained to the spec repo)

@Relequestual
Copy link
Member

Relequestual commented Mar 2, 2023

I have no idea why this is failing now when it didn't before.
I asked if this could be turned off back in 2021. The answer was no, and they weren't planning to add that option.

I do note, that on the current verison, the content uses the HTTPS version of that URL...

<link rel="schema.dct" href="[https://purl.org/dc/terms/](view-source:https://purl.org/dc/terms/)" />
https://json-schema.org/draft-04/json-schema-core.html line 421 (when you view source).

I do not know why this PR would trigger that error now though.

@KuSh
Copy link
Contributor Author

KuSh commented Mar 7, 2023

Checks pass after merging main

@Relequestual Relequestual merged commit 4b70748 into json-schema-org:main Mar 8, 2023
@KuSh KuSh deleted the patch-1 branch March 8, 2023 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants