Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Rename the implementation schema.js to jema.js #511

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

nuxodin
Copy link
Contributor

@nuxodin nuxodin commented Mar 28, 2023

I have decided to use a more unique name.

Aside:

Do you intend to release it as a package on a package manager (such as npm)?

done: https://www.npmjs.com/package/jema.js

Do you intend to continue development to resolve outstanding bugs (highlighted by failing tests)?

I have continued the development and fixed some bugs.

I have decided to use a more unique name.
@Relequestual
Copy link
Member

Thanks for your continued work on this.
I see the build is failing... I don't know why at this time, but I suspect it is unrelated to your changes.
I'll investigate further.

@Relequestual
Copy link
Member

Ah, I'm afraid it is to do with your PR. You accidentally renamed the file at the same time as modifying it.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for condescending-hopper-c3ed30 ready!

Name Link
🔨 Latest commit 15237e0
🔍 Latest deploy log https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/6422ace30476fb000818caba
😎 Deploy Preview https://deploy-preview-511--condescending-hopper-c3ed30.netlify.app/implementations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Relequestual Relequestual merged commit cf211cf into json-schema-org:main Mar 28, 2023
@nuxodin
Copy link
Contributor Author

nuxodin commented Mar 28, 2023

Ah, I'm afraid it is to do with your PR. You accidentally renamed the file at the same time as modifying it.

Oops that was not intentional.
Thanks for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants