This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Remove 2019-09 / 2020-12 support from networknt implementation #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for condescending-hopper-c3ed30 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gregsdennis
approved these changes
Jun 19, 2023
Relequestual
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Wow, that's pretty poor. It's hardly support. Yikes!
I'd call that misleading.
@Julian / @gregsdennis can we get this added to Bowtie?
(Edit: I thought it was .net for some reason... realise it says Java both here and on the repo)
|
Can you open an issue, I'll get to it sometime soon
…On Mon, Jun 19, 2023, 22:59 Ben Hutton ***@***.***> wrote:
Merged #525
<#525>
into main.
—
Reply to this email directly, view it on GitHub
<#525 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQQXRBKDUJSKP6PU62T5DXMC4SNANCNFSM6AAAAAAZLG2WI4>
.
You are receiving this because you were mentioned.Message ID:
<json-schema-org/json-schema-org.github.io/pull/525/issue_event/9572411495
@github.com>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
networknt/json-schema-validatorJava implementation has some major compliance gaps in 2019-09 and 2020-12 including only partial support for$idand$refand no support for$anchor,$dynamicRef, or$dynamicAnchor. With that much missing, I don't think our implementations page should claim that implementation supports those dialect.