This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Improve implementation draft list layout #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for condescending-hopper-c3ed30 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It's on purpose that 2019-09 and 2020-12 don't say "draft". We're trying to move away from that terminology for newer releases. |
This adds a comma between `draft` and `date-draft` items and checks for `empty` arrays to prevent stray "draft-0" output.
Ah, that makes sense. I updated this to just add the comma and check for |
jdesrosiers
approved these changes
Aug 21, 2023
Relequestual
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a comma between
draftanddate-draftitems and checks foremptyarrays to prevent stray "draft-0" output.Before:
After: