This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Controversial lifetime simplifications #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkmik I think this is good. Please could you rebase? |
I'm more than half way through the rust book and according to the lifetime elision rules described there we could simplify some of the signatures. While on one hand being explicit is good, there is an argument in favour of simplifying when possible: adding unnecessary annotations (lifetime or type decls) is bound to draw some attention when the next developer reads the code; they might pause to think why would that be necessary and it might thus cause distraction.
glyn
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm more than half way through the rust book and according to the lifetime elision rules described there
we could simplify some of the signatures.
While on one hand being explicit is good, there is an argument in favour of simplifying when possible:
adding unnecessary annotations (lifetime or type decls) is bound to draw some attention when the next
developer reads the code; they might pause to think why would that be necessary and it might thus cause distraction.