This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Use zip and find_map to unescape #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is possibly more elegant and also more robust as it panics if the escape sequence is not recognized. That said, we apply our tests against the parser (I have a PR with a unit test for this unescape but I realized it might be better to capture the test in the parser layer so it can be shared with other implementations).
|
superseded by #18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly more elegant and also more robust as it panics if the escape sequence is not recognized.
That said, we apply our tests against the parser (I have a PR with a unit test for this unescape
but I realized it might be better to capture the test in the parser layer so it can be shared with
other implementations).