Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Add developer guide #6

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add developer guide #6

merged 1 commit into from
Oct 1, 2020

Conversation

glyn
Copy link
Contributor

@glyn glyn commented Sep 29, 2020

No description provided.

@glyn glyn self-assigned this Sep 29, 2020
@glyn glyn requested a review from gregsdennis September 29, 2020 09:09
@glyn glyn marked this pull request as ready for review September 29, 2020 14:17
@glyn
Copy link
Contributor Author

glyn commented Sep 29, 2020

Thanks to @normyp for taking the dev guide for a spin on Windows!

@glyn glyn added the documentation Improvements or additions to documentation label Sep 29, 2020
@glyn glyn changed the title Add dev guide info to CONTRIBUTING.md Add developer guide Sep 30, 2020
DEVELOPING.md Outdated
cargo doc --document-private-items
```

Then open up `target/doc/jsonpath_reference_implementation/index.html` in a web browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then open up `target/doc/jsonpath_reference_implementation/index.html` in a web browser.
Then open up `target/doc/jsonpath_reference_implementation/index.html` in a web browser or pass `--open` to `cargo doc ...`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I prefer that approach. Modified.

Remove the VERBOSE flag from the tests and use built-in cargo facilities to
handle verbose output instead.

Improve the formatting of verbose test output.
@mkmik mkmik merged commit d27e6fd into jsonpath-standard:main Oct 1, 2020
@glyn glyn deleted the dev-guide branch October 1, 2020 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants