Skip to content

update sidecars to latest version #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2022
Merged

update sidecars to latest version #385

merged 2 commits into from
Nov 30, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Nov 3, 2022

/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2022
@humblec
Copy link
Contributor Author

humblec commented Nov 3, 2022

/assign @andyzhangx

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2022
ggriffiths
ggriffiths approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@ggriffiths ggriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@humblec humblec force-pushed the sidecar-update-20221103 branch from ae66dd9 to 5ea9a36 Compare November 5, 2022 05:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2022
@humblec humblec force-pushed the sidecar-update-20221103 branch 3 times, most recently from 3654f31 to be6408e Compare November 5, 2022 07:17
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2022
@coveralls
Copy link

coveralls commented Nov 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3582925783

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.209%
Totals Coverage Status
Change from base Build 3501685740: 0.0%
Covered Lines: 603
Relevant Lines: 781
💛 - Coveralls

@humblec
Copy link
Contributor Author

humblec commented Nov 5, 2022

@andyzhangx ptal..thanks!

@humblec
Copy link
Contributor Author

humblec commented Nov 8, 2022

/test pull-csi-driver-nfs-external-e2e

@andyzhangx
Copy link
Member

test-infra is broken now... waiting for fix

@humblec
Copy link
Contributor Author

humblec commented Nov 10, 2022

/test pull-csi-driver-nfs-external-e2e

@andyzhangx
Copy link
Member

/retest

@xing-yang
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2022
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@humblec
Copy link
Contributor Author

humblec commented Nov 16, 2022

/test pull-csi-driver-nfs-external-e2e

@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2022
@andyzhangx andyzhangx force-pushed the sidecar-update-20221103 branch from 3f3b02d to 546e303 Compare November 30, 2022 11:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@andyzhangx
Copy link
Member

I figured out the test failure, it's due to a mkdir bug in csi-node-driver-registrar v2.6.0 & v2.6.1, details: kubernetes-csi/node-driver-registrar#214, I have reverted to v2.5.1

@humblec
Copy link
Contributor Author

humblec commented Nov 30, 2022

@andyzhangx the fix is part of 2.6.0 of n-d-r sidecar. https://github.com/kubernetes-csi/node-driver-registrar/blob/release-2.6/CHANGELOG/CHANGELOG-2.6.md . If thats the case why its failing with those versions?

@andyzhangx
Copy link
Member

@andyzhangx the fix is part of 2.6.0 of n-d-r sidecar. https://github.com/kubernetes-csi/node-driver-registrar/blob/release-2.6/CHANGELOG/CHANGELOG-2.6.md . If thats the case why its failing with those versions?

@humblec I mean the fix is revert of this PR: kubernetes-csi/node-driver-registrar#247, v2.6.0 & v2.6.1 is actually broken now.

@andyzhangx
Copy link
Member

@andyzhangx the fix is part of 2.6.0 of n-d-r sidecar. https://github.com/kubernetes-csi/node-driver-registrar/blob/release-2.6/CHANGELOG/CHANGELOG-2.6.md . If thats the case why its failing with those versions?

@humblec I mean the fix is revert of this PR: kubernetes-csi/node-driver-registrar#247, v2.6.0 & v2.6.1 is actually broken now.

@humblec all test pass now!

andyzhangx
andyzhangx approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ggriffiths, humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8a90366 into kubernetes-csi:master Nov 30, 2022
@humblec
Copy link
Contributor Author

humblec commented Nov 30, 2022

@andyzhangx the fix is part of 2.6.0 of n-d-r sidecar. https://github.com/kubernetes-csi/node-driver-registrar/blob/release-2.6/CHANGELOG/CHANGELOG-2.6.md . If thats the case why its failing with those versions?

@humblec I mean the fix is revert of this PR: kubernetes-csi/node-driver-registrar#247, v2.6.0 & v2.6.1 is actually broken now.

ah.. then may be we have to open an issue at n-d-r repo @andyzhangx ? thanks for checking it and finding the RCA.

@andyzhangx
Copy link
Member

@humblec there is already an ask to publish a new release here: kubernetes-csi/node-driver-registrar#247 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths ggriffiths approved these changes

@andyzhangx andyzhangx andyzhangx approved these changes

@pohly pohly Awaiting requested review from pohly

Assignees

@xing-yang xing-yang

@ggriffiths ggriffiths

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@humblec @coveralls @andyzhangx @xing-yang @k8s-ci-robot @ggriffiths