-
Notifications
You must be signed in to change notification settings - Fork 1.2k
🌱examples-builtin: Refactor controller setup to use builder pattern #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: suzi1037 <[email protected]>
Welcome @s-z-z! |
Hi @s-z-z. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I test it, and it works correctly. here is the result command line operation
the rs got the label controller log
|
…By and move logging to ctrl.SetLogger Signed-off-by: suzi1037 <[email protected]>
LGTM label has been added. Git tree hash: d9614a9e1e60311c58ac2c07f5691c33c0914e5e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, s-z-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Refactors builtin example:
main.go
to usecontroller-runtime
builder pattern (ctrl.NewControllerManagedBy
) instead ofcontroller.New
for controller setup, consolidating ReplicaSet and Pod watches.Why
The builder pattern is the recommended approach for Kubernetes controllers, improving code readability, maintainability, and alignment with community practices.
Impact
No functional changes. Enhances code clarity and consistency with other projects.