Skip to content

MachineInstrBuilder: Introduce copyMIMetadata() function. #133535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pcc
Copy link
Contributor

@pcc pcc commented Mar 28, 2025

This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

pcc and others added 2 commits March 28, 2025 15:33
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
Copy link

github-actions bot commented Mar 28, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

pcc added a commit to pcc/llvm-project that referenced this pull request Apr 3, 2025
This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

Pull Request: llvm#133535
pcc added a commit to pcc/llvm-project that referenced this pull request Apr 4, 2025
This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

Pull Request: llvm#133535
pcc and others added 4 commits May 12, 2025 21:38
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
pcc added a commit to pcc/llvm-project that referenced this pull request May 24, 2025
This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

Pull Request: llvm#133535
pcc and others added 2 commits July 8, 2025 21:38
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
pcc and others added 2 commits July 9, 2025 20:35
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
pcc added a commit to pcc/llvm-project that referenced this pull request Jul 29, 2025
This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

Pull Request: llvm#133535
pcc added 2 commits July 29, 2025 21:51
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@pcc pcc requested review from arsenm and nikic July 30, 2025 22:11
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Something I don't entirely like is that MIMetadata holds DebugLoc, but copyMIMetadata does not copy it -- instead, it needs to be passed to CreateMachineInstr. But given how this is used it's not really a problem...

andykaylor and others added 2 commits July 31, 2025 09:52
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@pcc pcc changed the base branch from users/pcc/spr/main.machineinstrbuilder-introduce-copymimetadata-function to main July 31, 2025 16:52
@pcc pcc merged commit 7cdc978 into main Jul 31, 2025
9 of 15 checks passed
@pcc pcc deleted the users/pcc/spr/machineinstrbuilder-introduce-copymimetadata-function branch July 31, 2025 16:53
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Jul 31, 2025
This reduces the amount of boilerplate required when adding a new
field to MIMetadata and reduces the chance of bugs like the
one I fixed in TargetInstrInfo::reassociateOps.

Reviewers: arsenm, nikic

Reviewed By: nikic

Pull Request: llvm/llvm-project#133535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants