Skip to content

[SimplifyCFG] Extend jump-threading to allow live local defs #135079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 31, 2025
Merged

[SimplifyCFG] Extend jump-threading to allow live local defs #135079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
794dee4
Extend jump-threading to allow live local defs
LU-JOHN Apr 9, 2025
76d1864
Avoid two lookups
LU-JOHN Apr 18, 2025
e8b7574
Use using instead of typedef
LU-JOHN May 28, 2025
525f2fa
Do expensive reachesUsed test after inexpensive checks
LU-JOHN May 28, 2025
16b1f65
If we determine a block reaches non-local uses, record that result.
LU-JOHN May 29, 2025
0a0df38
Search for live blocks backward from uses. Add limit for searching
LU-JOHN Jun 2, 2025
9542ee7
Update test results
LU-JOHN Jun 3, 2025
847f6c0
Add more comments
LU-JOHN Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions clang/test/CodeGenObjC/exceptions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,18 +144,17 @@ void f4(void) {
// CHECK-NEXT: br label
// -> rethrow

// finally.call-exit: Predecessors are the @try and @catch fallthroughs
// as well as the no-match case in the catch mechanism. The i1 is whether
// to rethrow and should be true only in the last case.
// CHECK: phi ptr
// CHECK-NEXT: phi i1
// CHECK-NEXT: call void @objc_exception_try_exit(ptr nonnull [[EXNDATA]])
// finally.call-exit: Predecessor is the no-match case in the catch mechanism
// which rethrows.
// CHECK: call void @objc_exception_try_exit(ptr nonnull [[EXNDATA]])
// CHECK-NEXT: call void @f4_help(i32 noundef 2)
// CHECK-NEXT: br i1
// -> ret, rethrow
// CHECK-NEXT: br label
// -> rethrow

// ret:
// CHECK: ret void
// finally.end.critedge: Predecessors are the @try and @catch fallthroughs.
// CHECK: call void @objc_exception_try_exit(ptr nonnull [[EXNDATA]])
// CHECK-NEXT: call void @f4_help(i32 noundef 2)
// CHECK-NEXT: ret void

// Catch mechanism:
// CHECK: call ptr @objc_exception_extract(ptr nonnull [[EXNDATA]])
Expand Down
Loading
Loading