[llvm] using wrapper llvm::sort(nfc)

[Zhenhang1213]

using wrapper llvm::sort(nfc)

[llvmbot]

@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-llvm-transforms
@llvm/pr-subscribers-backend-hexagon

@llvm/pr-subscribers-llvm-ir

Author: Austin (Zhenhang1213)

Changes

using wrapper llvm::sort(nfc)

---

Full diff: https://github.com/llvm/llvm-project/pull/151000.diff

3 Files Affected:

• (modified) llvm/lib/Bitcode/Writer/BitcodeWriter.cpp (+1-1)
• (modified) llvm/lib/IR/AsmWriter.cpp (+1-1)
• (modified) llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp (+1-1)

diff --git a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
index e7ff772fc815a..3de289c6cfdeb 100644
--- a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
+++ b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
@@ -609,7 +609,7 @@ class IndexBitcodeWriter : public BitcodeWriterBase {
       std::vector<StringRef> ModulePaths;
       for (auto &[ModPath, _] : Index.modulePaths())
         ModulePaths.push_back(ModPath);
-      llvm::sort(ModulePaths.begin(), ModulePaths.end());
+      llvm::sort(ModulePaths);
       for (auto &ModPath : ModulePaths)
         Callback(*Index.modulePaths().find(ModPath));
     }
diff --git a/llvm/lib/IR/AsmWriter.cpp b/llvm/lib/IR/AsmWriter.cpp
index b21f4347f34d3..d1cd0c1c780d4 100644
--- a/llvm/lib/IR/AsmWriter.cpp
+++ b/llvm/lib/IR/AsmWriter.cpp
@@ -1160,7 +1160,7 @@ int SlotTracker::processIndex() {
   std::vector<StringRef> ModulePaths;
   for (auto &[ModPath, _] : TheIndex->modulePaths())
     ModulePaths.push_back(ModPath);
-  llvm::sort(ModulePaths.begin(), ModulePaths.end());
+  llvm::sort(ModulePaths);
   for (auto &ModPath : ModulePaths)
     CreateModulePathSlot(ModPath);
 
diff --git a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
index 52fa678a600e9..613048be52a2f 100644
--- a/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonISelDAGToDAGHVX.cpp
@@ -1987,7 +1987,7 @@ SmallVector<uint32_t, 8> HvxSelector::getPerfectCompletions(ShuffleMask SM,
   // times). In such cases it will be impossible to complete this to a
   // perfect shuffle.
   SmallVector<uint32_t, 8> Sorted(Worklist);
-  llvm::sort(Sorted.begin(), Sorted.end());
+  llvm::sort(Sorted);
 
   for (unsigned I = 0, E = Sorted.size(); I != E;) {
     unsigned P = Sorted[I], Count = 1;

[CoTinker]

Please change the sort with a comparator, such as:

llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp

Lines 239 to 241 in 7162f19

	llvm::sort(V.begin(), V.end(), [](const auto *L, const auto *R) {
	return L->getName() < R->getName();
	});

And the code below can be replaced with llvm::sort(operands());

llvm-project/llvm/lib/Transforms/Scalar/GVNSink.cpp

Line 311 in 0d05e55

llvm::sort(op_begin(), op_end());

[teresajohnson]

lgtm

[Zhenhang1213]

Please change the sort with a comparator, such as:

llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp

Lines 239 to 241 in 7162f19

	llvm::sort(V.begin(), V.end(), [](const auto *L, const auto *R) {
	return L->getName() < R->getName();
	});

And the code below can be replaced with llvm::sort(operands());

llvm-project/llvm/lib/Transforms/Scalar/GVNSink.cpp

Line 311 in 0d05e55

llvm::sort(op_begin(), op_end());

OK

[CoTinker]

And

llvm-project/llvm/lib/CodeGen/MIRPrinter.cpp

Lines 555 to 560 in d3f500f

	// Sort call info by position of call instructions.
	llvm::sort(YMF.CallSitesInfo.begin(), YMF.CallSitesInfo.end(),
	[](yaml::CallSiteInfo A, yaml::CallSiteInfo B) {
	return std::tie(A.CallLocation.BlockNum, A.CallLocation.Offset) <
	std::tie(B.CallLocation.BlockNum, B.CallLocation.Offset);
	});

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[CoTinker]

LGTM, thanks.