Ignore FileCheck when profcheck is enabled #151214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
✅ With the latest revision this PR passed the Python code formatter. |
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
53562e6 to
d92e17b
Compare
mtrofin
changed the base branch from
users/mtrofin/07-29-option_to_wildcard_xfail-not
to
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
d92e17b to
bc73ca5
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
from
26f7402 to
63de5c0
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
bc73ca5 to
6a45113
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
6a45113 to
5ae23e1
Compare
|
Not sure I understand, I think you mean "if I disable profcheck but still "do" this trick, does anything fail". No. |
That's what I was asking. I figured you had checked, but figured it wouldn't hurt to ask. |
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
from
63de5c0 to
0263d91
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
2 times, most recently
from
2bb0305 to
bf5c7e6
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
2 times, most recently
from
277936a to
a99c9c8
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
bf5c7e6 to
9f9b5f8
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
from
a99c9c8 to
ed3dd6b
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
9f9b5f8 to
218c4bf
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
from
ed3dd6b to
d678164
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
2 times, most recently
from
627ba43 to
a959caf
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-_nfc_test/lit.cfg.py_formatting
branch
from
d678164 to
5f27818
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
a959caf to
60275ac
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
24 times, most recently
from
1f3b25b to
5ffc407
Compare
mtrofin
force-pushed
the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
from
5ffc407 to
8cd5be2
Compare
mtrofin
deleted the
users/mtrofin/07-29-ignore_filecheck_when_profcheck_is_enabled
branch
|
Ya, went through the github side and didn't wait for the CI - it passed sufficient times already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profcheck is enabled (presumably on a specific build bot), we want to ignore FileCheck because we're only interested in profile validation, and some tests are sensitive to the precise IR output, which profile validation alters slightly by inserting profile metadata.
Issue #147390