[lldb] Pick the builder for the target platform #151262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick the builder for the target platform, not the host platform. This is necessary when running the test suite remotely on a different platform. Unlike for Darwin, both Windows and Linux us the default builder, which is why this went unnoticed on the remote-linux bots.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the builder selection mechanism in LLDB test suite to use the target platform instead of the host platform. This is essential for remote testing scenarios where tests run on a different platform than the host.
- Updated
builder_module()function to usegetPlatform()instead ofsys.platform - Added documentation to clarify the function's purpose
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesPick the builder for the target platform, not the host platform. This is necessary when running the test suite remotely on a different platform. Unlike for Darwin, both Windows and Linux us the default builder, which is why this went unnoticed on the remote-linux bots. Full diff: https://github.com/llvm/llvm-project/pull/151262.diff 1 Files Affected:
diff --git a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
index a1ab06076dcb2..cea6270695dc0 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
@@ -229,7 +229,8 @@ def hasChattyStderr(test_case):
def builder_module():
- return get_builder(sys.platform)
+ """Return the builder for the target platform."""
+ return get_builder(getPlatform())
def getArchitecture():
|
labath
approved these changes
Jul 30, 2025
JDevlieghere
added a commit
that referenced
this pull request
Jul 30, 2025
This reverts commit eb9e526.
JDevlieghere
added a commit
that referenced
this pull request
Jul 30, 2025
Reverts #151262 while I investigate why this breaks GreenDragon.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 30, 2025
…#151367) Reverts llvm/llvm-project#151262 while I investigate why this breaks GreenDragon.
JDevlieghere
added a commit
that referenced
this pull request
Jul 30, 2025
Pick the builder for the target platform, not the host platform. This is necessary when running the test suite remotely on a different platform. Unlike for Darwin, both Windows and Linux us the default builder, which is why this went unnoticed on the remote-linux bots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick the builder for the target platform, not the host platform. This is necessary when running the test suite remotely on a different platform. Unlike for Darwin, both Windows and Linux us the default builder, which is why this went unnoticed on the remote-linux bots.