Skip to content

[Hexagon] Add nounwind to hexagon-strcpy.ll #151293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

Conversation

svs-quic
Copy link
Contributor

The test does not check for anything related to cfi information so we don't really need them in the test checks. Also it looks like there were some failures on the Alpine Linux builders due to the placement of the cfi information in the output assembly.

I have also changed -march to -mtriple in the run line similar to 2208c97

@llvmbot
Copy link
Member

llvmbot commented Jul 30, 2025

@llvm/pr-subscribers-backend-hexagon

Author: Sudharsan Veeravalli (svs-quic)

Changes

The test does not check for anything related to cfi information so we don't really need them in the test checks. Also it looks like there were some failures on the Alpine Linux builders due to the placement of the cfi information in the output assembly.

I have also changed -march to -mtriple in the run line similar to 2208c97


Full diff: https://github.com/llvm/llvm-project/pull/151293.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/Hexagon/hexagon-strcpy.ll (+3-9)
diff --git a/llvm/test/CodeGen/Hexagon/hexagon-strcpy.ll b/llvm/test/CodeGen/Hexagon/hexagon-strcpy.ll
index b23366bc11aca..c064f0293a7d8 100644
--- a/llvm/test/CodeGen/Hexagon/hexagon-strcpy.ll
+++ b/llvm/test/CodeGen/Hexagon/hexagon-strcpy.ll
@@ -1,20 +1,15 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
-; RUN: llc -march=hexagon -verify-machineinstrs  < %s | FileCheck %s
+; RUN: llc -mtriple=hexagon -verify-machineinstrs  < %s | FileCheck %s
 
 @.str = private unnamed_addr constant [31 x i8] c"DHRYSTONE PROGRAM, 3'RD STRING\00", align 1
 @.str1 = private unnamed_addr constant [3 x i8] c"%s\00", align 1
 
-; Function Attrs: nounwind
 declare i32 @printf(i8* nocapture readonly, ...)
 
 ; Function Attrs: nounwind
-define i32 @main() {
+define i32 @main() nounwind{
 ; CHECK-LABEL: main:
-; CHECK:         .cfi_startproc
-; CHECK-NEXT:  // %bb.0: // %entry
-; CHECK-NEXT:    .cfi_def_cfa r30, 8
-; CHECK-NEXT:    .cfi_offset r31, -4
-; CHECK-NEXT:    .cfi_offset r30, -8
+; CHECK:       // %bb.0: // %entry
 ; CHECK-NEXT:    {
 ; CHECK-NEXT:     r0 = ##.L.str1
 ; CHECK-NEXT:     r3:2 = CONST64(#2325073635944967245)
@@ -53,5 +48,4 @@ entry:
   ret i32 0
 }
 
-; Function Attrs: nounwind
 declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture, i8* nocapture readonly, i32, i32, i1)

@svs-quic svs-quic merged commit 3796efb into llvm:main Jul 31, 2025
9 checks passed
@svs-quic svs-quic added this to the LLVM 21.x Release milestone Jul 31, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Jul 31, 2025
@svs-quic
Copy link
Contributor Author

/cherry-pick 3796efb

@llvmbot
Copy link
Member

llvmbot commented Jul 31, 2025

/pull-request #151458

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Jul 31, 2025
@svs-quic svs-quic deleted the hexagon_test branch July 31, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants