[Instrumentor] A configurable instrumentation pass plugin #151551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both internally and externally we instrument code all the time. Usually, those are hand written traversals that look for some specific instructions or program points and then provide information to a runtime. Since the real difference is in the runtime, and the instrumentation is basically always the same, people can use this Instrumentor pass and configure it to their needs. Initial implementation only instruments alloca instructions but shows the setup, and configurability via a JSON file.
|
I guess we don't want another generic plugin like Bye? 👋 I integrated the Instrumentor pass from #119038 |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass plugins are a commonly requested extension for LLVM-based tools. Better support for these extensions benefits the LLVM ecosystem and might slow down the growth of the monorepo. We currently lack test coverage for pass plugins, because we only have example plugins (and no reference), but most bots don't build examples. As a result we also can't test cross-project integration. Features like parsing of plugin parameters in Clang remain broken and get no attention.
This draft adds a reference plugin in LLVM that we can test in subprojects. For illustration, it comes with tests for plugin parameters and pipeline entry-points.