Skip to content

[libc] fix build errors caused by atanhf16. #151838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bassiounix
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bassiounix bassiounix marked this pull request as ready for review August 2, 2025 20:26
@llvmbot llvmbot added the libc label Aug 2, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2025

@llvm/pr-subscribers-libc

Author: Muhammad Bassiouni (bassiounix)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/151838.diff

1 Files Affected:

  • (modified) libc/src/__support/math/atanhf16.h (+1-1)
diff --git a/libc/src/__support/math/atanhf16.h b/libc/src/__support/math/atanhf16.h
index 9146e1e31b815..80929dd30fa34 100644
--- a/libc/src/__support/math/atanhf16.h
+++ b/libc/src/__support/math/atanhf16.h
@@ -109,7 +109,7 @@ static constexpr float LOG_F_FLOAT[128] = {
 // x should be positive, normal finite value
 // TODO: Simplify range reduction and polynomial degree for float16.
 //       See issue #137190.
-LIBC_INLINE static constexpr float log_eval_f(float x) {
+LIBC_INLINE static float log_eval_f(float x) {
   // For x = 2^ex * (1 + mx), logf(x) = ex * logf(2) + logf(1 + mx).
   using FPBits = fputil::FPBits<float>;
   FPBits xbits(x);

@bassiounix bassiounix force-pushed the users/bassiounix/spr/08-02-_libc_fix_build_errors_caused_by_atanhf16 branch from 1db66d5 to ea9bf21 Compare August 2, 2025 20:36
Copy link
Contributor Author

bassiounix commented Aug 2, 2025

Merge activity

  • Aug 2, 8:37 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 2, 8:43 PM UTC: @bassiounix merged this pull request with Graphite.

@bassiounix bassiounix merged commit 5f83387 into main Aug 2, 2025
19 checks passed
@bassiounix bassiounix deleted the users/bassiounix/spr/08-02-_libc_fix_build_errors_caused_by_atanhf16 branch August 2, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants