Skip to content

release/21.x: [Flang] Fix crash with parametrized derived types usage (#150289) #151937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/21.x
Choose a base branch
from
+31 −2
Open

release/21.x: [Flang] Fix crash with parametrized derived types usage (#150289) #151937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions flang/lib/Lower/Mangler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,18 @@ std::string Fortran::lower::mangle::mangleName(
assert(paramExpr && "derived type kind param not explicit");
std::optional<int64_t> init =
Fortran::evaluate::ToInt64(paramValue->GetExplicit());
assert(init && "derived type kind param is not constant");
kinds.emplace_back(*init);
// TODO: put the assertion check back when parametrized derived types
// are supported:
// assert(init && "derived type kind param is not constant");
//
// The init parameter above will require a FoldingContext for proper
// expression evaluation to an integer constant, otherwise the
// compiler may crash here (see example in issue #127424).
if (!init) {
TODO_NOLOC("parameterized derived types");
} else {
kinds.emplace_back(*init);
}
}
}
return fir::NameUniquer::doType(modules, procs, blockId, symbolName, kinds);
Expand Down
19 changes: 19 additions & 0 deletions flang/test/Lower/parametrized-derived-types.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
! XFAIL: *
program main
TYPE ty(k1,k2)
INTEGER ,KIND::k1,k2=5
INTEGER::arr(k1:k2)=10
CHARACTER(LEN=k2)::CHARACTER
END TYPE ty
TYPE,EXTENDS(ty)::ty1(k3)
INTEGER,KIND ::k3=4
TYPE(ty(2,k3+1))::cmp_ty = ty(2,k3+1)(55,'HI')
END TYPE ty1
TYPE ty2(l1, l2)
!ERROR: not yet implemented: parameterized derived types
INTEGER,LEN ::l1,l2
TYPE(ty1(2,5)), ALLOCATABLE::ty1_cmp(:)
END TYPE ty2
TYPE(ty2(4,8)) ::ty2_obj
end program main
Loading