[Flang-RT] Do not use Apple-specific libdir scheme #151954
Draft
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luporl
reviewed
Aug 4, 2025
Comment on lines
+37
to
+38
| get_toolchain_arch_dirname(arch_dirname) | ||
| set(outval "${outval}/${arch_dirname}") |
There was a problem hiding this comment.
On my machine, both compiler-rt and flang-rt libraries are installed into <install_dir>/lib/clang/22/lib/darwin.
IIUC, this change would make flang-rt libraries be installed in a new directory, <install_dir>/lib/clang/22/lib/<target>, right?
Wouldn't it be better to make flang look for its libraries in the same path as compiler-rt?
|
This patch didn't change the behavior for me, unfortunately. |
|
This did not resolve the problem because the new ___location is not in the linker's search path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-target x86_64-apple-darwin, flang looks for the following directories:lib/x86_64-apple-darwinlib/darwin/x86_64while
get_toolchain_library_subdirreturned the following dir:lib/darwinThe
APPLEexception was copied over from compiler-rt. Either it doesn't work there either, or was not adapted correctly.We remove the special Apple handling such that flang-rt is emitted into
lib/x86_64-apple-darwin.Fixes #151031