[Minidump] Update Minidump file builder to continue when the Module's section cannot be found #152009
+38
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 4, 2025 10:13
Jlalond
requested changes
Aug 4, 2025
| module_name.c_str(), E.message().c_str()); | ||
| } | ||
| }); | ||
| } else { |
There was a problem hiding this comment.
You can just continue; in the guard clause
| m_data.AppendData(&successful_modules_count, | ||
| sizeof(llvm::support::ulittle32_t)); | ||
|
|
||
| for (size_t i = 0; i < modules_count; ++i) { |
There was a problem hiding this comment.
This won't work,
Imagine you have 7 modules, and the 6th fails, You will attempt to read the 6th once twice. So what you want to do is extract all the modules into a vector, then write it.
Jlalond
requested changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning an error when:
when we encounter such an error we log the error and continue with the other modules.
tested with lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py