-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[AMDGPU] Add fixed size to wmma instructions with scale #152043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rampitec
merged 14 commits into
main
from
users/rampitec/08-04-_amdgpu_add_fixed_size_to_wmma_instructions_with_scale
Aug 5, 2025
Merged
[AMDGPU] Add fixed size to wmma instructions with scale #152043
rampitec
merged 14 commits into
main
from
users/rampitec/08-04-_amdgpu_add_fixed_size_to_wmma_instructions_with_scale
Aug 5, 2025
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not see it affecting any existing tests though. |
changpeng
approved these changes
Aug 4, 2025
@llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) ChangesFull diff: https://github.com/llvm/llvm-project/pull/152043.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
index 5d186c337a99c..ca85fe1ca9073 100644
--- a/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP3PInstructions.td
@@ -1664,11 +1664,15 @@ multiclass WMMAInstGFX12<string Instr, VOP3PWMMA_Profile WMMAProfile, string Pse
let Constraints = WMMAConstraints2Addr, isConvertibleToThreeAddress = 1 in
def _twoaddr : VOP3P_Pseudo<Instr, WMMAProfile>, WMMAInstInfo {
let PseudoInstr = Instr#PseudoInstrSuffix;
+ let FixedSize = WMMAProfile.HasMatrixScale;
+ let Size = !if(WMMAProfile.HasMatrixScale, 16, 8);
}
let Constraints = WMMAConstraints3Addr, SchedRW = [Write32Bit, Write32Bit] in
def _threeaddr : VOP3P_Pseudo<Instr, WMMAProfile>, WMMAInstInfo {
let PseudoInstr = Instr#PseudoInstrSuffix;
+ let FixedSize = WMMAProfile.HasMatrixScale;
+ let Size = !if(WMMAProfile.HasMatrixScale, 16, 8);
}
}
|
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
…to_wmma_instructions_with_scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.