Minor updates for best practices/linting/security #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathanmcgarvey-modopayments
commented
Jun 21, 2023
nathanmcgarvey-modopayments
commented
- minor security enhancements in helm chart
- minor best-practices/linting (E.g. using select{} instead of a ifinite loop with sleep, using log.Print vs fmt.Print, formatted the imports, etc.)
- minor readme changes (linting for links and header sizes, removal/change for dead link(s), and addition of some other log collectors like Promtail and Logstash)
- bump go to 1.20 to pull in some security fixes
- bump k8s.io deps to v0.24.15 (note that this version is about to become non-maintained, but still is for now)
- minor best-practices/linting (E.g. using select{} instead of a ifinite loop with sleep, using log.Print vs fmt.Print, formatted the imports, etc.)
- minor readme changes (linting for links and header sizes, removal/change for dead link(s), and addition of some other log collectors like Promtail and Logstash)
- bump go to 1.20 to pull in some security fixes
- bump k8s.io deps to v0.24.15 (note that this version is about to become non-maintained, but still is for now)
|
|
||
| ```sh | ||
| make IMG=maxrocketinternet/k8s-event-logger TAG=latest | ||
| make all IMG=<your-container-registry>/k8s-event-logger TAG=latest |
There was a problem hiding this comment.
This does the the full multi-arch setup, too. (the "all" target, that is). I found it easier to test with that and then a make clean afterwards, but feel free to reject this for the simpler make image.
|
|
||
| [multi-platform image]: https://docs.docker.com/build/building/multi-platform/ | ||
| [qemu-binfmt]: https://docs.nvidia.com/datacenter/cloud-native/playground/x-arch.html |
There was a problem hiding this comment.
dead link
Comment on lines
+6
to
+8
| k8s.io/api v0.24.15 | ||
| k8s.io/apimachinery v0.24.15 | ||
| k8s.io/client-go v0.24.15 |
There was a problem hiding this comment.
Up to k8s 1.27 now, versions are only +/- 1 compatible, or in some circumstances +/- 2. So this probably needs to be bumped at some point in the near future.
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| appVersion: "1.8" | |||
| version: "1.1.3" | |||
| appVersion: "1.9" | |||
There was a problem hiding this comment.
Let's go for 2.0 since this is the largest update this project has had since being created 🙂
Suggested change
| appVersion: "1.9" | |
| appVersion: "2.0" |
| drop: | ||
| - ALL | ||
| seccompProfile: | ||
| type: RuntimeDefault |
There was a problem hiding this comment.
I also made these changes to the hosted chart: deliveryhero/helm-charts#490
max-rocket-internet
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.