Skip to content

fix: switches to a getter for API consistency #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.OpenApi/Expressions/CompositeExpression.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
public class CompositeExpression : RuntimeExpression
{
private readonly string template;
private Regex expressionPattern = new(@"{(?<exp>\$[^}]*)");
private readonly Regex expressionPattern = new(@"{(?<exp>\$[^}]*)");

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

Check warning on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

View workflow job for this annotation

GitHub Actions / Build

Pass a timeout to limit the execution time. (https://rules.sonarsource.com/csharp/RSPEC-6444)

/// <summary>
/// Expressions embedded into string literal
/// </summary>
public List<RuntimeExpression> ContainedExpressions = new();
public List<RuntimeExpression> ContainedExpressions { get; } = new();

/// <summary>
/// Create a composite expression from a string literal with an embedded expression
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ namespace Microsoft.OpenApi
}
public class CompositeExpression : Microsoft.OpenApi.RuntimeExpression
{
public System.Collections.Generic.List<Microsoft.OpenApi.RuntimeExpression> ContainedExpressions;
public CompositeExpression(string expression) { }
public System.Collections.Generic.List<Microsoft.OpenApi.RuntimeExpression> ContainedExpressions { get; }
public override string Expression { get; }
}
public class CurrentKeys
Expand Down
Loading