Skip to content

[ADD] xml version 1.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2019
Merged

[ADD] xml version 1.0 #2

merged 1 commit into from
Jan 14, 2019

Conversation

oscars8a
Copy link
Contributor

Hi,
In first , a lot of thanks for this pluggin for vcode. It's very helpfull.

I think it's usefull add this line, "", because is necesary in a xml type file and when I use "odata" snip, it's because the file is new and it's empty, without this line.

@mstuttgart mstuttgart self-requested a review January 14, 2019 14:05
@mstuttgart mstuttgart added the enhancement New feature or request label Jan 14, 2019
@mstuttgart
Copy link
Owner

Hi @oscars8a ! Thanks for PR! 😄

Please, can you merge your commits in one commit? You can use this steps:

git reset --soft abf76ab8749ab5911c330f3b61a206aaf798adb8
git commit -am "[IMP] Add XML version tag"
git push -f origin develop

@oscars8a
Copy link
Contributor Author

Hi @oscars8a ! Thanks for PR!

Please, can you merge your commits in one commit? You can use this steps:

git reset --soft abf76ab8749ab5911c330f3b61a206aaf798adb8
git commit -am "[IMP] Add XML version tag"
git push -f origin develop

Sorry it's my first PR, thanks again

Copy link
Owner

@mstuttgart mstuttgart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @oscars8a . Thanks again! 😃

@mstuttgart mstuttgart merged commit 28559cb into mstuttgart:develop Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants