[FIX] early close data tag #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstuttgart
requested changes
Jan 16, 2019
There was a problem hiding this comment.
Hi @oscars8a thanks! 👍
Before merge your PR, can you update you local branch (to fix you git history)? 😄
git remote add upstream [email protected]:mstuttgart/vscode-odoo-snippets.git
git fetch --all
git pull --rebase upstream develop
git push -f origin develop
After this, please use:
git commit --amend
to change message commit to [FIX] Early close data tag
Thanks again 👍
The data tag close two times, in lines 411 and 414.
mstuttgart
approved these changes
Jan 17, 2019
|
Thanks again, I need to learn git flow jeje 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
The data tag close two times, in lines 411 and 414.
See you next time.