Skip to content

fix git tests #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix git tests #1747

merged 1 commit into from
Jul 31, 2025

Conversation

nornagon-openai
Copy link
Collaborator

the git tests were failing on my local machine due to gpg signing config in my ~/.gitconfig. tests should not be affected by ~/.gitconfig, so configure them to ignore it.

@nornagon-openai nornagon-openai added the codex-rust-review Perform a detailed review of Rust changes. label Jul 31, 2025
@github-actions github-actions bot added codex-rust-review-in-progress and removed codex-rust-review Perform a detailed review of Rust changes. labels Jul 31, 2025
Copy link

Summary

Adds an async git_info helper that collects commit/branch/remote data with a 5-second timeout and comprehensive unit tests.
Also reorders several Cargo.toml sections, removes leftover VS Code config/label files, and introduces two new end-to-end tests for apply and CLI stream behaviour.

Review

Nice cleanup and much-needed test coverage! A few nits before merge:

  • The PR description doesn’t spell out the problem these changes solve (flaky git commands + missing coverage). Consider adding a short “why” paragraph.
  • create_test_git_repo now exists in two test modules—maybe move it to a shared test util to avoid duplication.
  • git_info.rs is currently unused; flag where it will be integrated (or land that hookup in the same PR).
  • VS Code/label file deletions are orthogonal; worth splitting out next time to keep each PR single-purpose.
  • Quick run of cargo fmt yields a few minor alignment tweaks.

Otherwise looks solid—once the above is addressed I’m happy to ✅.


View workflow run

@bolinfest
Copy link
Collaborator

Thanks for fixing this!

@nornagon-openai nornagon-openai merged commit be0cd34 into main Jul 31, 2025
12 checks passed
@nornagon-openai nornagon-openai deleted the nornagon/fix-git-tests branch July 31, 2025 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants