Added Microsoft Entra ID Support for Keyless Auth #1778
+213
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
pbezglasny
reviewed
Aug 1, 2025
| pub fn load_auth( | ||
| codex_home: &Path, | ||
| model_provider_name: &str, | ||
| env_key: &Option<String>, |
There was a problem hiding this comment.
It is better to use Option<&str> than &Option<String>.
With Option<&str>, you can pass None directly without reference and convert Option<String> to Option<&str> by calling as_deref() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces support for Microsoft Entra ID as a keyless authentication method for Azure OpenAI, refactors token handling, and enhances configuration and error management across multiple modules. The changes primarily focus on enabling seamless integration with Azure services, improving token caching mechanisms, and updating the authentication logic. It follows up on some of @thegovind's work [#769, #92] adding support for Azure OpenAI, but now in the new Rust API and without introducing any new dependencies to the project.
Why?
Many companies have API keys disabled (Microsoft is one example) for security reasons preventing access to
codex. This would allow for more developers to be able to use the CLI.Changes
Support for Microsoft Entra ID and Azure OpenAI Integration:
AuthMode::MicrosoftEntraIDto support keyless authentication via Microsoft Entra ID. Updated token retrieval logic to use Azure CLI for fetching access tokens and implemented caching with expiration checks (codex-rs/login/src/lib.rs). [1] [2]load_authfunction to handle Azure-specific configurations, including environment variables and model provider names (codex-rs/login/src/lib.rs). [1] [2]run_login_status,run_main,init_codex, etc.) to pass model provider details for authentication (codex-rs/cli/src/login.rs,codex-rs/cli/src/proto.rs,codex-rs/core/src/codex_wrapper.rs,codex-rs/tui/src/lib.rs). [1] [2] [3] [4]Configuration Enhancements:
config.md, including instructions for setting up Azure CLI and modifying thecodexconfiguration file (codex-rs/config.md). [1] [2]ModelClientfor Azure-specific API requirements, ensuring proper URL construction (codex-rs/core/src/client.rs). [1] [2]Code Refactoring and Cleanup:
client.rsto improve readability and removed unused dependencies (codex-rs/core/src/client.rs). [1] [2]codex-rs/login/src/lib.rs). [1] [2]Error Handling Improvements:
codex-rs/core/src/client.rs,codex-rs/login/src/lib.rs). [1] [2]codex-rs/login/src/lib.rs).