Skip to content

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 28, 2025

This pull request resolves #1585; the only thing this SDK needs to do is to upgrade underlying openai package the latest version, which is done by #1599

@seratch seratch requested a review from rm-openai August 28, 2025 04:35
@seratch seratch added documentation Improvements or additions to documentation feature:core feature:mcp labels Aug 28, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +51 to +52
if verbose:
for item in res.new_items:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Use streamed result instead of undefined res when verbose

When stream=True the code never assigns to res, yet the verbose block always references res.new_items. Calling the example with --stream --verbose (or main(True, True)) will raise UnboundLocalError: cannot access local variable 'res' after the streaming loop completes, so verbose streaming currently cannot work.

Useful? React with 👍 / 👎.

@seratch seratch merged commit b5bf795 into main Aug 28, 2025
5 checks passed
@seratch seratch deleted the issue-1585-connectors branch August 28, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature:core feature:mcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add connector support
2 participants