Auth provider that leaves room for future challenge auth to be implemented #2571
+388
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaders, query parameters and challenge auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Enable custom authentication mechanisms for the OpenAI client similar to what is supported with the bearer token provider for the AzureOpenAI client.
The auth instance itself is a protocol that takes (target) url, query parameters, headers and cookies as input and returns updated values, which should allow for the vast majority of auth scenarios for most service and api gateways put in front of the service (oauth, header based api keys w. arbitrary header names, cookie based auth, challenge requests).
In order to enable challenge auth, we'd have to plug it in to the request pipeline of the client and respond to 401 responses rather than just retrying the request (passing in the 401 response to the do_auth method of the auth provider).
Additional context & links