Enhancement: Tag clients #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jun 21, 2019
| @@ -419,6 +419,7 @@ function ($id) { | |||
| ->addArgument([ | |||
| 'client_name' => $clientName, | |||
| ]) | |||
| ->addTag('httplug.client') | |||
There was a problem hiding this comment.
i'd make this a public constant so that things using the tag can use it explicitly.
There was a problem hiding this comment.
Adjusted!
I'll update the documentation as well.
localheinz
force-pushed
the
feature/tag
branch
2 times, most recently
from
1f7d439 to
f92cd2a
Compare
This was referenced Jun 21, 2019
localheinz
force-pushed
the
feature/tag
branch
2 times, most recently
from
074bc0e to
aa0102d
Compare
dbu
approved these changes
Jul 5, 2019
|
Rebased! |
|
Thank you, @dbu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR
'httplug.client'to clients created by theHttplugExtensionWhy?
This would allow fetching services by tag and replacing them, for example, with a concrete
Mock\Client, without having to know the exact service identifier.Checklist