Skip to content

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 8, 2018

@ruudk ruudk force-pushed the query-defaults branch 3 times, most recently from 69a7a39 to 0360e69 Compare November 13, 2018 09:32
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me apart from a sphinx nitpick and the defaultUserAgent copy-paste

@ruudk
Copy link
Contributor Author

ruudk commented Nov 13, 2018

@dbu Updated PR

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@dbu dbu merged commit f37f0d7 into php-http:master Nov 13, 2018
@ruudk ruudk deleted the query-defaults branch November 13, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants