Skip to content

Commit 776d6f8

Browse files
committed
Add valgrind instruction count meansurement support to manual benchmark flow
1 parent e8f88e7 commit 776d6f8

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

.github/workflows/real-time-benchmark.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,15 @@ on:
1111
jit:
1212
description: 'Whether JIT is benchmarked'
1313
required: false
14+
default: "0"
15+
type: choice
16+
options:
17+
- "0"
18+
- "1"
19+
instruction_count:
20+
description: 'Whether Valgrind instruction count should be measured'
21+
required: true
22+
default: "0"
1423
type: choice
1524
options:
1625
- "0"
@@ -50,6 +59,7 @@ jobs:
5059
OPCACHE: ${{ inputs.opcache || '1' }}
5160
BASELINE_OPCACHE: ${{ inputs.baseline_opcache || '2' }}
5261
JIT: ${{ inputs.jit || '1' }}
62+
INSTRUCTION_COUNT: ${{ inputs.instruction_count || '0' }}
5363
YEAR: ""
5464
steps:
5565
- name: Setup benchmark environment
@@ -130,6 +140,7 @@ jobs:
130140
cp ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini.dist ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
131141
ESCAPED_DOCKER_REGISTRY=$(printf '%s\n' "${{ secrets.PHP_VERSION_BENCHMARK_DOCKER_REGISTRY }}" | sed -e 's/[\/&]/\\&/g')
132142
sed -i "s/INFRA_DOCKER_REGISTRY=public.ecr.aws\/abcdefgh/INFRA_DOCKER_REGISTRY=$ESCAPED_DOCKER_REGISTRY/g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
143+
sed -i "s/INFRA_MEASURE_INSTRUCTION_COUNT=0/INFRA_MEASURE_INSTRUCTION_COUNT=${{ env.INSTRUCTION_COUNT }}/g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
133144
cp ./php-version-benchmarks/build/infrastructure/config/aws.tfvars.dist ./php-version-benchmarks/build/infrastructure/config/aws.tfvars
134145
sed -i 's/access_key = ""/access_key = "${{ secrets.PHP_VERSION_BENCHMARK_AWS_ACCESS_KEY }}"/g' ./php-version-benchmarks/build/infrastructure/config/aws.tfvars
135146
sed -i 's/secret_key = ""/secret_key = "${{ secrets.PHP_VERSION_BENCHMARK_AWS_SECRET_KEY }}"/g' ./php-version-benchmarks/build/infrastructure/config/aws.tfvars

0 commit comments

Comments
 (0)