Add stubs for security factories #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
force-pushed
the
security-factory
branch
from
b5320d6 to
cf085c8
Compare
yguedidi
force-pushed
the
security-factory
branch
from
cf085c8 to
e63e830
Compare
ondrejmirtes
requested changes
Mar 27, 2023
| /** | ||
| * @param array<string, mixed> $config | ||
| * | ||
| * @return string|string[] |
There was a problem hiding this comment.
When does it return a string and when does it return an array?
There was a problem hiding this comment.
It depends on the concrete implementation, for example:
- string: https://github.com/symfony/symfony/blob/6.3/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/AccessTokenFactory.php#L70
- array: https://github.com/symfony/symfony/blob/6.3/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/CustomAuthenticatorFactory.php#L60
There was a problem hiding this comment.
Returning a string is treated the same than returning an array containing a single item by the Symfony code calling this factory. It allows to simplify the most common case which only needs to create a single authenticator.
There was a problem hiding this comment.
@ondrejmirtes is there anything else I can do?
stof
approved these changes
Apr 4, 2023
|
Thank you! |
1 similar comment
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref symfony/symfony#49783