Fix stub of Voter::supports() method #368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Oct 30, 2023
| @@ -13,10 +13,11 @@ abstract class Voter implements VoterInterface | |||
| /** | |||
| * Determines if the attribute and subject are supported by this voter. | |||
| * | |||
| * @param mixed $subject | |||
| * @phpstan-param TAttribute $attribute | |||
There was a problem hiding this comment.
This is a wrong fix because it's okay to ask about anything in supports. The TAttribute is typehinted only in voteOnAttribute because only valid TAttribute can be passed there. But in supports you can ask about whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #367