Fix internal error when DIC param map has > 256 items #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like we should make a rule in PHPStan so that ConstantArrayTypeBuilder is used instead of
That's too late, you can't return a different type from a class constructor. Otherwise I think this is the right fix. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure happened here.
Generally, this feels like a trap inside PHPStan. If any
ConstantArrayTypewill fail when used inimplodeor just with any usage ofTypeUtils::flattenTypes, it is just not safe to create it by constructor and the degradation logic inConstantArrayTypeBuildershould be imo moved toConstantArrayTypeconstructor.Or maybe just
getAllArraysneeds to be fixed? IDK where is the proper place to fix this.