-
Notifications
You must be signed in to change notification settings - Fork 96
Add template for AclProviderInterface #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09bbc06
to
3d4b034
Compare
ondrejmirtes
requested changes
Aug 14, 2020
5341349
to
6503151
Compare
I need phpstan/phpstan#3111 first Opened phpstan/phpstan-src#301 |
@ondrejmirtes I removed the |
82b4158
to
297b4bb
Compare
297b4bb
to
ecf6a52
Compare
@ondrejmirtes I rebase master ; this PR is ready to merge |
Hi, I'm sorry, but this PR does too many things at once and it's unlikely to be merged.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ondrejmirtes
If I understand correctly template and I didn't make any mistake, this PR seems better than symfony/security-acl#60.
By the way I have two others questions:
stubFiles
config ? This way the following code would be enough.