Skip to content

1966 ListItemAttachments cancel event is hanging the control #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025

Conversation

Ateina
Copy link
Contributor

@Ateina Ateina commented Apr 27, 2025

Q A
Bug fix? [ X ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1966

Improve upload flow: detect when user cancels file picker

  • Detects when the file picker dialog closes
  • Uses window focus to catch dialog closure after the file input is clicked.
  • Cleans up listeners properly to avoid issues.
  • Triggers onUploadDialogClosed when needed.

@joaojmendes joaojmendes self-assigned this Jul 13, 2025
@joaojmendes joaojmendes added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jul 13, 2025
@joaojmendes joaojmendes added this to the 3.22.0 milestone Jul 13, 2025
@joaojmendes
Copy link
Collaborator

@Ateina Thank you for your fix.

@joaojmendes joaojmendes merged commit 6aef5be into pnp:dev Jul 13, 2025
1 check passed
@Ateina Ateina deleted the 1966-ListItemAttachments-cancel-event branch July 15, 2025 20:46
@Ateina Ateina restored the 1966-ListItemAttachments-cancel-event branch July 20, 2025 21:14
@Ateina
Copy link
Contributor Author

Ateina commented Jul 23, 2025

Hi @joaojmendes @michaelmaillot @joelfmrodrigues !
Sorry if I'm missing something, but I couldn’t find the changes from this PR in the dev or master branches, same for PRs #1976 and #1990.
Could you please advise if they were merged into a different branch or are still pending?

@joelfmrodrigues
Copy link
Collaborator

@Ateina many thanks for bringing this to our attention! We will review and let you know once resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants