Skip to content

Hotfix for issue 2014 #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

Hotfix for issue 2014 #2016

merged 2 commits into from
Jul 13, 2025

Conversation

wuxiaojun514
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #2014

What's in this Pull Request?

Right now user cannot clean up the choice field (the issue only occurs on single choice, multiple choice doesn't have this problem) in Dynamic Form.
This hotfix will allow user remove the selected choice.

demo on optional field:
choiceWithOpitionField

demo on required field:

choiceWithRequiredField

I created a new child control under dynamic field folder to implement this clean up functionality.
Please feel free to let me know if I need modify something (UI, Naming...).

@joaojmendes joaojmendes self-assigned this Jul 13, 2025
@joaojmendes joaojmendes added the status:fixed Issue fixed in current or prior release. label Jul 13, 2025
@joaojmendes joaojmendes added this to the 3.22.0 milestone Jul 13, 2025
@joaojmendes
Copy link
Collaborator

@wuxiaojun514 Thank you for your fix.

@joaojmendes joaojmendes merged commit cc22428 into pnp:dev Jul 13, 2025
1 check passed
@wuxiaojun514
Copy link
Contributor Author

Hi @joaojmendes ,
I found my PR didn't merged into dev branch successfully.
The merged commit says "does not belong to any branch on this repository, and may belong to a fork outside of the repository."
image

I also checked some other nearby PRs (e.g. #2009 ,#2001,#2007...) and found they have the same problems (The commit says "does not belong to any branch on this repository"). This is quite weird...

I wonder shall I create a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed Issue fixed in current or prior release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants