Skip to content

Fix edge case with leading line ending in 'split_lines'. #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix edge case with leading line ending in 'split_lines'. #1982

merged 2 commits into from
Apr 10, 2025

Conversation

jonathanslenders
Copy link
Member

No description provided.

@jonathanslenders jonathanslenders merged commit 75786f6 into master Apr 10, 2025
12 checks passed
@joouha
Copy link
Contributor

joouha commented Aug 16, 2025

Hi Jonathan,
I was just wondering what was the rational behind this change?
From my perspective, it results in the generation of unnecessary extra style-and-text tuples around new-lines with no content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanslenders @joouha