Follow-up after #19025: test and cleanup #19294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sterliakov
changed the title
sterliakov
force-pushed
the
hotfix/st-restore-is-staticmethod
branch
from
e022f9c to
3bbd0d6
Compare
This comment has been minimized.
This comment has been minimized.
|
The primer change is bad but unrelated. Opened #19358 to address it. |
This comment has been minimized.
This comment has been minimized.
hauntsaninja
pushed a commit
that referenced
this pull request
Jun 30, 2025
…mapping (#19358) This was discovered in #19294 where an unrelated change produced a weird notice that should not be shown. Current behavior of the added testcase: ``` main.py:10: error: Argument 1 to "foo" has incompatible type "*list[object]"; expected "P" [arg-type] main.py:10: note: "list" is missing following "P" protocol member: main.py:10: note: arg main.py:11: error: Argument 1 to "foo" has incompatible type "**dict[str, object]"; expected "P" [arg-type] main.py:11: note: "dict" is missing following "P" protocol member: main.py:11: note: arg ``` https://mypy-play.net/?mypy=master&python=3.12&flags=strict&gist=d0228ba7d2802db8ac4457f374ccc148
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Aug 3, 2025
|
Oh well, now the test fails because type var ids need to be updated. I am too lazy to checkout and fix myself, so I will wait for you :-) |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @ilevkivskyi in #19025