-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Update update_data.py: make the space in error comments optional #19546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ah, there are a lot of urls with fragments in there. Hmm. Maybe the whole parser should be changed and simplified... Or perhaps just match space and beginning of line. |
Why the hell am I still getting test failures like
|
I added a .strip to it... it's then constructed with a template string... what the hell... [edit: commit with .strip not pictured in current branch history] |
Oh... |
for more information, see https://pre-commit.ci
Amusingly, this seems to have uncovered several problems with the expected values in some test cases, which I will now fix... |
Make the spaces in test error comments optional and more flexible, so instead of
#E: whatever
you can now write# E: whatever
(for example). This will prevent people from erroneously entering error lines which are then ignored. Fixes #19547.I have written tests for this feature, but have not affirmatively documented it, because I don't want to encourage irregularity in the error comments people write.
Amusingly, this seems to have uncovered several problems with the expected values in some test cases, which I have also fixed. These fixes fell into 3 categories:
# E:
or an# N:
type: ignore
command not recognized after other comment #19366# E :
, so now that that syntax with the interstitial space is valid the E triggers. I turned this one into an xfail instead, based on what it was doing.