Skip to content

Add status bar compilation status item #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Conversation

zth
Copy link
Member

@zth zth commented Aug 21, 2025

This adds a status bar item that tracks compilation status - ok, compiling, errors, warnings. It's behind a setting, although I did default to make it turned on.

Let me know what you think! Some images:

Compiling

Pasted Graphic 4

Ok

Chronicler V ReScript Ok

Warnings

Pasted Graphic 3

Failed

Chronicler

@zth zth requested review from nojaf and Copilot August 21, 2025 10:09
@zth
Copy link
Member Author

zth commented Aug 21, 2025

Cc @mediremi

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mediremi
Copy link
Contributor

Tried it locally and works great 👍

I think we should mention the rescript.settings.compileStatus.enable setting in the README's Settings section and potentially in the changelog entry too, so anyone who wants to disable this doesn't have to search too much.

@zth
Copy link
Member Author

zth commented Aug 21, 2025

@mediremi ahh nice catch! Done in ab7da06.

@zth zth requested a review from mediremi August 21, 2025 12:59
Copy link
Contributor

@mediremi mediremi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@zth zth merged commit ecf4be4 into master Aug 21, 2025
6 checks passed
@zth zth deleted the compilation-status-status-bar-item branch August 21, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants