Implement `push_mut` #135975

balt-dev · 2025-01-24T05:43:00Z

Implementation of #135974.

rustbot · 2025-01-24T05:43:08Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ibraheemdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

balt-dev · 2025-01-24T05:44:26Z

Sorry if I did this wrong, it's my first time!

ibraheemdev · 2025-01-25T22:56:36Z

I'm not sure we should be touching Vec::push here.. maybe just duplicate the implementation?

balt-dev · 2025-01-26T00:42:09Z

Alright, I'll do that soon.

library/alloc/src/vec/mod.rs

balt-dev · 2025-02-22T03:00:32Z

@rustbot review

library/alloc/src/vec/mod.rs

ibraheemdev · 2025-02-23T01:04:41Z

library/alloc/src/vec/mod.rs

+    ///
+    /// let mut vec = vec![];
+    /// // Due to current borrow checker limitations (see -Zpolonius), this is the only way to spell this right now.
+    /// let last = if let Some(v) = vec.last_mut() { v } else { vec.push_mut(0) };


I'm not sure I understand the point of this.

There should probably be a better example, yeah. Will update soon!

alex-semenyuk · 2025-04-06T10:35:10Z

@balt-dev
Thanks for your contribution
From wg-triage. Any updates on this PR?

balt-dev · 2025-05-31T05:05:46Z

I think I messed up my fork so bad I'll have to reset it and put my code in from scratch in order to get rid of the merge commit. At least it's copy/pasteable?

tgross35

LGTM, please just squash

balt-dev · 2025-07-30T16:45:27Z

Will do!

rustbot · 2025-07-30T17:24:34Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

balt-dev · 2025-07-30T17:25:19Z

...oops.

balt-dev · 2025-07-30T17:27:47Z

Accidentally got a little overzealous with my git rebase -i HEAD~4. How do I remove the A-attributes label?

sayantn · 2025-07-30T17:58:01Z

@rustbot label -A-attributes

balt-dev · 2025-07-30T18:31:51Z

@sayantn Thank you!

WaffleLapkin · 2025-07-30T18:35:43Z

If this gets merged as-is, please update the tracking issue to include all added methods.

tgross35 · 2025-07-30T18:59:47Z

Thank you for all the persistence in getting this over the line! Hopefully the next PR will be a bit smoother :)

@bors r+

If this gets merged as-is, please update the tracking issue to include all added methods.

Argh, this whole time I was thinking this was all in the ACP. The VecDeque/LinkedList portion is a logical extension of push_mut and Mara did chime in about the signature for insert above, so I think it's fine without kicking it back to libs-api. Cc @rust-lang/libs-api in case anyone has any concerns.

I updated the tracking issue.

bors · 2025-07-30T18:59:51Z

📌 Commit 3ccfa14 has been approved by tgross35

It is now in the queue for this repository.

Implement `push_mut` Implementation of rust-lang#135974.

Rollup of 6 pull requests Successful merges: - #135975 (Implement `push_mut`) - #143672 (Fix Box allocator drop elaboration) - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend) - #144663 (coverage: Re-land "Enlarge empty spans during MIR instrumentation") - #144683 (Simplify library dependencies on `compiler-builtins`) - #144685 (Only extract lang items once in codegen_fn_attrs) r? `@ghost` `@rustbot` modify labels: rollup

Implement `push_mut` Implementation of #135974.

bors · 2025-07-31T05:13:54Z

⌛ Testing commit 3ccfa14 with merge 7581ecc...

Zalathar · 2025-07-31T05:42:47Z

Yielding to enclosing rollup:

@bors retry

Rollup of 6 pull requests Successful merges: - #135975 (Implement `push_mut`) - #143672 (Fix Box allocator drop elaboration) - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend) - #144663 (coverage: Re-land "Enlarge empty spans during MIR instrumentation") - #144685 (Only extract lang items once in codegen_fn_attrs) - #144717 (Move `rustc_middle::parameterized`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-31T08:53:35Z

⌛ Testing commit 3ccfa14 with merge cc0a5b7...

Rollup merge of #135975 - balt-dev:master, r=tgross35 Implement `push_mut` Implementation of #135974.

Implement `push_mut` Implementation of rust-lang#135974.

rustbot assigned ibraheemdev Jan 24, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025

balt-dev mentioned this pull request Jan 24, 2025

Tracking Issue for Vec::push_mut #135974

Open

3 tasks

This comment has been minimized.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

ibraheemdev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025

This comment was marked as off-topic.

Sign in to view

balt-dev commented Feb 17, 2025

View reviewed changes

library/alloc/src/vec/mod.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2025

ibraheemdev requested changes Feb 23, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label May 31, 2025

This comment was marked as off-topic.

Sign in to view

balt-dev closed this May 31, 2025

balt-dev force-pushed the master branch from 149aab8 to 7a7bcbb Compare May 31, 2025 05:06

tgross35 approved these changes Jul 30, 2025

View reviewed changes

balt-dev force-pushed the master branch from c953b84 to cc575af Compare July 30, 2025 17:24

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Jul 30, 2025

Implement push_mut

3ccfa14

balt-dev force-pushed the master branch from cc575af to 3ccfa14 Compare July 30, 2025 17:26

rustbot removed the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Jul 30, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Jul 31, 2025

Rollup merge of rust-lang#135975 - balt-dev:master, r=tgross35

1211650

Implement `push_mut` Implementation of rust-lang#135974.

Zalathar mentioned this pull request Jul 31, 2025

Rollup of 6 pull requests #144709

Closed

bors added a commit that referenced this pull request Jul 31, 2025

Auto merge of #135975 - balt-dev:master, r=tgross35

7581ecc

Implement `push_mut` Implementation of #135974.

Zalathar mentioned this pull request Jul 31, 2025

Rollup of 6 pull requests #144718

Merged

bors merged commit dc8aec4 into rust-lang:master Jul 31, 2025
10 of 11 checks passed

rustbot added this to the 1.90.0 milestone Jul 31, 2025

rust-timer added a commit that referenced this pull request Jul 31, 2025

Unrolled build for #135975

de3e33f

Rollup merge of #135975 - balt-dev:master, r=tgross35 Implement `push_mut` Implementation of #135974.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 2, 2025

Rollup merge of rust-lang#135975 - balt-dev:master, r=tgross35

f4d1221

Implement `push_mut` Implementation of rust-lang#135974.

Implement push_mut #135975

Implement push_mut #135975

Conversation

balt-dev commented Jan 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 24, 2025

Uh oh!

balt-dev commented Jan 24, 2025

Uh oh!

This comment has been minimized.

This comment was marked as off-topic.

This comment has been minimized.

ibraheemdev commented Jan 25, 2025

Uh oh!

balt-dev commented Jan 26, 2025

Uh oh!

This comment was marked as off-topic.

Uh oh!

balt-dev commented Feb 22, 2025

Uh oh!

Uh oh!

ibraheemdev Feb 23, 2025

Choose a reason for hiding this comment

Uh oh!

balt-dev Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

alex-semenyuk commented Apr 6, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment has been minimized.

This comment was marked as off-topic.

balt-dev commented May 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

balt-dev commented Jul 30, 2025

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

balt-dev commented Jul 30, 2025

Uh oh!

balt-dev commented Jul 30, 2025

Uh oh!

sayantn commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balt-dev commented Jul 30, 2025

Uh oh!

WaffleLapkin commented Jul 30, 2025

Uh oh!

tgross35 commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 30, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Zalathar commented Jul 31, 2025

Uh oh!

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Uh oh!

Implement `push_mut` #135975

Implement `push_mut` #135975

balt-dev commented Jan 24, 2025 •

edited by rustbot

Loading

balt-dev commented May 31, 2025 •

edited

Loading

sayantn commented Jul 30, 2025 •

edited

Loading

tgross35 commented Jul 30, 2025 •

edited

Loading